-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove export timeout configuration for PeriodicReader #2598
Remove export timeout configuration for PeriodicReader #2598
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2598 +/- ##
=====================================
Coverage 79.0% 79.0%
=====================================
Files 119 119
Lines 22550 22531 -19
=====================================
- Hits 17830 17819 -11
+ Misses 4720 4712 -8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will include this in migration guide I am preparing.
We need to mention the fact that rogue observable instruments can stall entire sdk in some docs.
Fixes: towards #2576
Changes
Similar to #2587
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes