Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove export timeout configuration for PeriodicReader #2598

Merged

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Feb 3, 2025

Fixes: towards #2576

Changes

Similar to #2587

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner February 3, 2025 22:40
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.0%. Comparing base (15b5fa4) to head (bdffeb8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2598   +/-   ##
=====================================
  Coverage   79.0%   79.0%           
=====================================
  Files        119     119           
  Lines      22550   22531   -19     
=====================================
- Hits       17830   17819   -11     
+ Misses      4720    4712    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will include this in migration guide I am preparing.
We need to mention the fact that rogue observable instruments can stall entire sdk in some docs.

@cijothomas cijothomas merged commit 5f7f2d5 into open-telemetry:main Feb 5, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants