Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual instrumentation doc for .NET #1014

Merged
merged 4 commits into from
Dec 23, 2021

Conversation

cartermp
Copy link
Contributor

@cartermp cartermp commented Dec 22, 2021

Contributes to #1001 (but really contributes to the implicit ".NET has no docs" issue).

Also contributes to:

#974
#973

@cartermp cartermp requested a review from a team December 22, 2021 23:08
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after a quick glance. I'll let @austinlparker et all do a detailed read. If this is still open when I get back, I can make a careful pass too.

(Thanks for naming the file manual.md right from the start!)

Copy link
Member

@austinlparker austinlparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm outside of comments.

@austinlparker austinlparker merged commit 1f529ef into open-telemetry:main Dec 23, 2021
@cartermp cartermp deleted the cartermp.dotnet-manual branch December 23, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants