Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll-the-dice application for PHP #2758

Merged
merged 6 commits into from
May 24, 2023
Merged

Roll-the-dice application for PHP #2758

merged 6 commits into from
May 24, 2023

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented May 22, 2023 •
edited
Loading

@svrnm svrnm requested review from a team May 22, 2023 10:04
cartermp
cartermp approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, will defer to @open-telemetry/php-approvers for code changes

@svrnm svrnm merged commit 8cecba8 into open-telemetry:main May 24, 2023
@svrnm svrnm deleted the roll-the-dice-for-php branch May 24, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@brettmc brettmc brettmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svrnm @brettmc @cartermp