-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8s annotation discovery blogpost #5967
base: main
Are you sure you want to change the base?
Conversation
e8de438
to
f6215ae
Compare
FYI @open-telemetry/docs-maintainers sth is odd with the 2025 index page and I cannot find the preview page that is built. I assume it's because there is no prior blog post for 2025 and something is missing there but not sure what. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A first pass! This is a really great feature I was not aware coming, so great to have a blog post.
Note: we should also think about turning some of that into documentation immediatly otherwise this gets dated and people will refer to it as docs, would you be able to provide that as well? Could be a very basic page with an example to begin with
author: > | ||
[Dmitrii Anoshin](https://github.com/dmitryax) (Cisco/Splunk), [Christos | ||
Markou](https://github.com/ChrsMark) (Elastic) | ||
cSpell:ignore: Dmitrii Anoshin Markou |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cSpell:ignore: Dmitrii Anoshin Markou | |
sig: Collector | |
issue: opentelemetry-collector-contrib#34427 | |
cSpell:ignore: Dmitrii Anoshin Markou |
We ask SIG members as well to make sure that their blog posts are sponsored, I assume that the Collector SIG has agreed to publish this and is going to review, so I will not ask you to raise an additional issue, but please add these annotations (see https://opentelemetry.io/docs/contributing/blog/ for more details)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good to know. I will also share it with the Collector SIG to check if there is any objection/feedback from the wider group.
cSpell:ignore: Dmitrii Anoshin Markou | ||
--- | ||
|
||
In the world of containers and Kubernetes, observability is crucial. Users need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the world of containers and Kubernetes, observability is crucial. Users need | |
In the world of containers and [Kubernetes](https://kubernetes.io/), observability is crucial. Users need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
that makes dynamic workload discovery even easier, providing a seamless | ||
experience for both administrators and users. | ||
|
||
## What is Autodiscovery in Observability? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## What is Autodiscovery in Observability? | |
## Automatic discovery for containers and pods |
Is "Autodiscovery" a specific term for this technique, or is this section explaining how auto discovery works? The text does not give any hint on "what" but provides a "how"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
## What is Autodiscovery in Observability? | ||
|
||
Applications running on containers and pods become moving targets for the | ||
monitoring system. With autodiscovery, monitoring agents like the Collector can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
monitoring system. With autodiscovery, monitoring agents like the Collector can | |
monitoring system. With automatic discovery, monitoring agents like the Collector can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
``` | ||
|
||
The above configuration will be enabled when a pod is discovered via the | ||
Kubernetes API that exposes port 6379 (the known port for Redis). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kubernetes API that exposes port 6379 (the known port for Redis). | |
Kubernetes API that exposes port `6379` (the known port for Redis). |
configuration "templates" that rely on environment conditions. For example, as | ||
an observability engineer, I can configure my Collector to enable the | ||
[Redis receiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/v0.117.0/receiver/redisreceiver) | ||
when a Redis pod is deployed on the cluster. The following configuration can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe I am very pedantic here, but since Redis is no longer open source, wouldn't it be better to pick something wie an OSI-approved open source license for the example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can use NGINX which is our example further down as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that would be great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
f6215ae
to
3183ec2
Compare
3763d98
to
d6bcd8c
Compare
Thank's for reviewing @svrnm! About turning this into documentation: I linked the last paragraph to the perspective documentation of that feature in the Collector: https://github.com/open-telemetry/opentelemetry.io/pull/5967/files#diff-4fa372b70b4ce1ad702b596ad6f06decb547f6de4dd4ca979ffeee2bac298f72R182. Would we need more than this? |
I mean adding a section/page somewhere in https://opentelemetry.io/docs/collector/ |
My only concern would be that we would need to maintain that source in addition to receiver's README, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me 🚀 Just a couple nits/typos. with the caveats that I'm not a native English speaker, so my suggestions might be incorrect. Feel free to discard them.
854f6a1
to
f6a43c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is only this one file, then rename this to content/en/blog/2025/otel-collector-k8s-discovery.md
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Done.
67993ab
to
0eb852e
Compare
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12919783314 |
IMPORTANT: (RE-)RUN
|
187d487
to
ef477e5
Compare
Co-authored-by: Dmitrii Anoshin <[email protected]> Signed-off-by: ChrsMark <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
9608188
to
99b4e01
Compare
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
623fb64
to
3018504
Compare
This PR adds a blog post about the new functionality of the Opentelemetry Collector which was introduced with open-telemetry/opentelemetry-collector-contrib#34427.
With this new feature now the Collector provides support for dynamic workload discovery based on Kubernetes Pods's annotations.
Preview: https://deploy-preview-5967--opentelemetry.netlify.app/blog/2025/otel-collector-k8s-discovery/
/cc @dmitryax