Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to 0.117.0 #277

Merged
merged 2 commits into from
Jan 14, 2025
Merged

feat: update to 0.117.0 #277

merged 2 commits into from
Jan 14, 2025

Conversation

Erog38
Copy link
Contributor

@Erog38 Erog38 commented Jan 14, 2025

Hey all,

I notices the concurrentbatchprocessor was on 0.114.0, so I'm submitting this PR which simply bumps versions to support 0.117.0

@lquerel
Copy link
Contributor

lquerel commented Jan 14, 2025

@jmacd could you please take a look at this PR. Thanks

@Erog38
Copy link
Contributor Author

Erog38 commented Jan 14, 2025

It needs mdatagen run still, but I haven't run it before so I'm digging into that a moment

@Erog38
Copy link
Contributor Author

Erog38 commented Jan 14, 2025

I ran this through mdatagen but got build errors where the generated files:

  1. added a dependency on configtelemetry which wasn't used
  2. was missing "go.opentelemetry.io/otel/metric/noop"
  3. was missing "go.opentelemetry.io/otel/metric"

My IDE fixed this automatically, but it's worth mentioning that mdatagen didn't generate this correctly at first 🤔

@Erog38
Copy link
Contributor Author

Erog38 commented Jan 14, 2025

I do claim that I should've filed an issue first 😅 Just hoped I could take this off someone's plate.

Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow there were no code changes needed. The collector APIs are stabilizing, that's great.
Thank you!

@jmacd
Copy link
Contributor

jmacd commented Jan 14, 2025

I also remember there being problems with mdatagen (I wonder if there was mdatagen mismatch?), but I read the diffs and everything looks OK. Thank you!

@jmacd jmacd merged commit 1948605 into open-telemetry:main Jan 14, 2025
2 checks passed
jmacd added a commit that referenced this pull request Jan 17, 2025
@drewrelmas drewrelmas mentioned this pull request Jan 24, 2025
jmacd pushed a commit that referenced this pull request Jan 24, 2025
- Make a generic `AttributesStore` in pkg/arrow.
[#276](#276)
- Update to v0.117.0 collector dependencies.
[#277](#277),
[#279](#279)
- Deprecate local versions of `fileexporter` and `filereceiver` in favor
of upstream components with related README changes.
[#278](#278)
- Made an incremental step towards deprecating `MetricsLevel` usage in
the project.
[#283](#283)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants