-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge *.cpu.state attributes to a common cpu.mode attribute #1026
Conversation
de27ecd
to
dbd49a4
Compare
57eee6d
to
beb92b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think you need to re-generate the make generate-gh-issue-templates
though
Thank's @joaopgrassi. For some reason the |
848fa37
to
a7e9c02
Compare
@open-telemetry/semconv-system-approvers could you take a look and specifically into the #1026 (comment)? Thank's. |
Changed to |
Co-authored-by: Alexandra Konrad <[email protected]>
Co-authored-by: Alexandra Konrad <[email protected]>
Co-authored-by: Alexandra Konrad <[email protected]>
Co-authored-by: Alexandra Konrad <[email protected]>
Co-authored-by: Alexandra Konrad <[email protected]>
Co-authored-by: Alexandra Konrad <[email protected]>
You need to regenerate registry to update md files to fix the issue |
Signed-off-by: ChrsMark <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just left a few minor comments.
Co-authored-by: Liudmila Molkova <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>
Co-authored-by: Braydon Kains <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Fixes #840
Changes
This PR introduces a common
cpu.state
cpu.mode
attribute which is a converged attribute from thesystem.cpu.state
,process.cpu.state
andcontainer.cpu.state
.Merge requirement checklist
[chore]