-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event.summary as a recommendation for events #1074
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# Use this changelog template to create an entry for release notes. | ||
# | ||
# If your change doesn't affect end users you should instead start | ||
# your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: enhancement | ||
|
||
# The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
component: events | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Add a human-readable description as an attribute representing the event | ||
|
||
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
# The values here must be integers. | ||
issues: [ 1076 ] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: | | ||
Events are identified by an `event.name` and a set of attributes and fields in the body that carry specific | ||
meaning. However, since these events will be combined with other logs, `event.description` allows a | ||
centralized logging system to display a human-readable representation of the event. |
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -16,3 +16,18 @@ groups: | |||||||||||
separation of semantics for events in separate domains like browser, mobile, and | ||||||||||||
kubernetes. | ||||||||||||
examples: ['browser.mouse.click', 'device.app.lifecycle'] | ||||||||||||
- id: summary | ||||||||||||
type: string | ||||||||||||
stability: experimental | ||||||||||||
brief: > | ||||||||||||
Human-readable summary representing an event. | ||||||||||||
note: > | ||||||||||||
Events are identified by an `event.name` and a set of attributes and fields in the body that carry specific | ||||||||||||
meaning. However, since these events will be combined with other logs, `event.summary` allows a | ||||||||||||
centralized logging system to display a human-readable representation of the event. | ||||||||||||
|
||||||||||||
Comment on lines
+25
to
+28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This paragraph does not seem to provide new information - it's already captured in the event name, the markdown, and the brief. Could it be removed?
Suggested change
|
||||||||||||
When summaries are generated, they are not expected to include every attribute and field that is part of the | ||||||||||||
event but could contain those that are meaningful for a human operator when visually navigating a centralized | ||||||||||||
log system. Instrumentation libraries that produce events defined within the standard OpenTelemetry are not | ||||||||||||
expected to add an `event.summary` attribute, as these are well-known events. | ||||||||||||
Comment on lines
+29
to
+32
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we make it normative? E.g.
Suggested change
I removed
I'm not sure how it could work - if we have 100+ events defined, no backend would be able to special-case each event and define human-readable representation of it. I.e. I don't understand why we would NOT allow to define a summary for at least some standards events. |
||||||||||||
examples: ['User clicked element with id 42', 'Device app lifecycle changed to PAUSED'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be event.summary