Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute name and const names checks #1209

Merged
merged 16 commits into from
Jul 31, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Jul 3, 2024

Fixes #1068
Implements phase 1 of #1118 (comment)

image

@lmolkova lmolkova marked this pull request as ready for review July 24, 2024 06:27
@lmolkova lmolkova requested review from a team July 24, 2024 06:27
@lmolkova lmolkova added the Skip Changelog Label to skip the changelog check label Jul 24, 2024
Makefile Show resolved Hide resolved
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just left two comments that I don’t think are blocking.

policies/attribute_name_collisions.rego Show resolved Hide resolved
policies/registry.rego Outdated Show resolved Hide resolved
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit.

policies/attribute_name_collisions.rego Show resolved Hide resolved
policies/attribute_name_collisions.rego Show resolved Hide resolved
@lmolkova lmolkova merged commit d182f9e into open-telemetry:main Jul 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Label to skip the changelog check
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add attribute naming checks
5 participants