Add k8s.{pod,node}.network.{io,errors} metrics #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrsMark
force-pushed
the
add_k8s_network_metrics
branch
2 times, most recently
from
5d093f4 to
a7fe139
Compare
5 tasks
lmolkova
reviewed
Oct 11, 2024
ChrsMark
force-pushed
the
add_k8s_network_metrics
branch
from
ddd42d2 to
c7f3653
Compare
ChrsMark
requested review from
a team
and removed request for
a team and
tigrannajaryan
ChrsMark
force-pushed
the
add_k8s_network_metrics
branch
from
c7f3653 to
804d91a
Compare
|
@lmolkova @TylerHelmuth thank's for reviewing this. We are now using the new |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@TylerHelmuth @lmolkova anything blocking this one? |
TylerHelmuth
approved these changes
Nov 18, 2024
|
/cc @open-telemetry/specs-semconv-maintainers @lmolkova |
3 tasks
lmolkova
approved these changes
Nov 21, 2024
|
@ChrsMark please regenerate markdown files (there was a small change on main) and it should be ready to go. |
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
ChrsMark
force-pushed
the
add_k8s_network_metrics
branch
from
eaa88aa to
618fc90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1032
Fixes #1487
Changes
This PR adds the following metrics:
k8s.pod.network.iok8s.pod.network.errorsk8s.node.network.iok8s.node.network.errorsThe above metrics are already used in the Collector in the kubeletstats receiver and the naming is aligned with the System metrics.
These metrics come with the following attributes
network.io.directionandsystem.devicewhich are already part of SemConv registry and are used in the System metrics. The attributes in the Collector will need to be adjusted to follow the recent SemConv rules.Merge requirement checklist
[chore]