Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add k8s semconv migration non-normative doc #1597

Merged
merged 9 commits into from
Dec 5, 2024

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Nov 20, 2024

Part of #1537

Changes

This PR adds the non-normative k8s semconv migration docs described by #1537.

So far it only includes changes from #1427 but the goal is to keep adding content in this file as we go.

This PR is blocked until #1427 is merged.

Merge requirement checklist

/cc @TylerHelmuth

@ChrsMark ChrsMark requested a review from a team November 20, 2024 10:34
@ChrsMark ChrsMark marked this pull request as ready for review November 26, 2024 10:15
@ChrsMark ChrsMark requested review from a team as code owners November 26, 2024 10:15
@ChrsMark ChrsMark force-pushed the k8s-migration branch 2 times, most recently from c822cd2 to 44155db Compare November 26, 2024 10:18
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark
Copy link
Member Author

ChrsMark commented Dec 2, 2024

v1.29.0 release is out (this includes the changes this current doc references).

@TylerHelmuth @mx-psi shall we proceed with this or is there anything else missing here?

docs/non-normative/k8s-migration.md Outdated Show resolved Hide resolved
docs/non-normative/k8s-migration.md Outdated Show resolved Hide resolved
@ChrsMark
Copy link
Member Author

ChrsMark commented Dec 4, 2024

It would be helpful to have this in soon, so we can use it as base for listing the upcoming changes, i.e. in #1636.

The only leftover here seems to be the names of the feature gates: #1597 (comment)

@ChrsMark
Copy link
Member Author

ChrsMark commented Dec 5, 2024

FYI @open-telemetry/specs-semconv-maintainers we have a lot of approvals already here.

.github/CODEOWNERS Show resolved Hide resolved
@trask trask merged commit 106f880 into open-telemetry:main Dec 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants