Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add
origin_referrer_url
andorigin_url
to the file attribute #1430base: main
Are you sure you want to change the base?
add
origin_referrer_url
andorigin_url
to the file attribute #1430Changes from all commits
968e8c2
ec834e6
160b7ee
37c9710
4a2fed9
481bd1c
a2b4b35
4b11936
a1a4867
e8256e6
c55cb2b
130bf61
1f6663a
329df10
ba508e4
f4ad750
d82f261
c6b8d78
b0016f6
7d5331c
ed796cc
f4e241c
264fd13
b590595
0793ef9
17107e4
a3dfd75
daa081e
22d06ab
088e959
358f21a
71c4edf
92ceab6
8eb5600
43ad199
b763b83
581b0e0
bb17dcd
e3fbf82
1ba436d
2493537
cd068b6
8972382
774b768
13c7f29
00e95bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we qualify what open means? Below you mention it's actually an access event (which could probably mean other things, like setting/getting metadata). Should it be called
file.access
then?Does it intend to capture OS-level audit events like https://learn.microsoft.com/en-us/previous-versions/windows/it-pro/windows-10/security/threat-protection/auditing/event-4663 or https://github.com/linux-audit/audit-userspace?tab=readme-ov-file#events?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add note on who/how/when should emit this event.
E.g. OTel instrumentations are usually run in a certain process and would usually 1) monitor things this process does (not OS-wide things) 2) set
process
attributes as resource attributes, not as event attributes (because resource attributes are shared for the process lifetime and it's much more efficient).If it's an external observer that monitors something on the OS level, we should call it out.
If it's either, then we should explain how and if process attributes should be recorded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lmolkova (CC: @trisch-me, @jsuereth )
Thanks you for the feedback!
As you pointed out, it was my misunderstanding—I was imagining OS-level events. (Since ECS can also handle that information, I ended up confusing the two)
I'm not very familiar with the internal structure of Otel's instrumentation, so to be honest, it's difficult for me to provide an answer at this point. If possible, could you please share the specific technical documentation for the Otel instrumentation you're referring to? Additionally, if OS-level events are not expected, who is expected to send the
file.access
orfile.open
events? Could you share any assumptions or scenarios you had in mind?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can imagine a few scenarios for such events:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it always known when file is opened?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be time it was accessed before it was opened this time? Is it available? Otherwise, it'd be the same as event timestamp and then it's not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if file was attempted to be opened, but it failed - do we want to record this event? If so, we should add
error.type
attribute to it.