add origin_referrer_url and origin_url to the process attribute
#1517
Conversation
Co-authored-by: Alexandra Konrad <[email protected]>
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
AsuNa-jp
changed the title
origin_referrer_url, origin_url and zone_identifier to the process attributeorigin_referrer_url, origin_url to the process attribute
AsuNa-jp
changed the title
origin_referrer_url, origin_url to the process attributeorigin_referrer_url and origin_url to the process attribute
|
Since this is a property of the process's executable, and not of a process itself, I think it makes more sense for these attributes to be |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@AsuNa-jp could you update this PR and address comments? thanks |
|
Hi @braydonk @trisch-me
|
| brief: > | ||
| The URL of the webpage that linked to the process's executable file. | ||
| note: > | ||
| This information comes from metadata or alternate data streams linked to the process's executable file. |
There was a problem hiding this comment.
Non-blocking, can be merged without resolving this unless there's a good answer.
@open-telemetry/specs-semconv-maintainers is there a better way to specify a note like this in the YAML? This results in two separate identical notes being generated in the markdown. A way to make one note about this that could be linked by both attributes would be nice, but as far as I know there isn't a way to do that right?
There was a problem hiding this comment.
there is no way to do this currently afaik, because we are not linking notes, it happens automatically
Changes
This PR adds the following attributes. (Updated Dec/25/2024)
process.executable.origin_referrer_urlprocess.executable.origin_urlDetails
Generally, a process is generated from an executable file. Therefore, the process model naturally includes attributes containing information about the originating executable file. In this PR, we are adding the following two attributes to further extend the originating executable file details.
process.executable.origin_referrer_urlprocess.executable.origin_urlThe name of these attributes and where to add it were decided after consulting with @joe-desimone and @trisch-me.
The meaning of each field is explained in detail in the PR below.
Merge requirement checklist
[chore]