-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RabbitMQ: Specify how to populate messaging.destination.name
#1531
Open
joaopgrassi
wants to merge
29
commits into
open-telemetry:main
Choose a base branch
from
dynatrace-oss-contrib:rabbitmq-destination-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+46
−21
Open
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
d9574a8
Specify destination name for RabbitMQ
joaopgrassi 6efe0b3
Add changelog
joaopgrassi b02ff2a
Add queue to destination name
joaopgrassi 29209ae
Lint
joaopgrassi 52f57bb
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi 9fdf75d
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi f953d89
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi 42768c9
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi 8567f58
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi 70bdbdf
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi 0598254
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi cbab7c9
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi 69b8141
simply and remove queue from dest name
joaopgrassi 47dc2c0
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi ca4034f
rollback
joaopgrassi 210cea0
PR suggestions
joaopgrassi 275e760
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi c87df8f
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi f48427f
Add guidance on yaml file
joaopgrassi 839f0cb
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi bde99d0
make destination name required for rabbitmq and remove batching case
joaopgrassi 0eb8b2f
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi b6bbc85
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi 40c1410
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi d537c6d
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi 568f90c
Pr suggestions
joaopgrassi b668ff2
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi 359cf02
fix typo
joaopgrassi 7000965
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
change_type: breaking | ||
component: messaging | ||
note: "RabbitMQ: Specify how to populate `messaging.destination.name`" | ||
issues: [1529] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can there be an
{exchange}
but not a{routing key}
, or can there be a{routing key}
but not a{exchange}
? it may be helpful to be explicit about fallback options (if any), in particular, do you drop the:
or not when only one of them is present, here's an example where we cover these fallbacks: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/database/database-spans.md#nameThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah they can be empty like that AFAIK. I adapted it a bit, hopefully it is clearer now.