Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messaging: Clarify {destination} value used on span name #1635

Conversation

joaopgrassi
Copy link
Member

@joaopgrassi joaopgrassi commented Nov 29, 2024

Fixes #1532

Changes

  • Make it explicit that {destination} should not be used in high cardinality scenarios (e.g., when the destination is temporary or anonymous)

Merge requirement checklist

@trask
Copy link
Member

trask commented Dec 13, 2024

looks like needs a change log entry

@joaopgrassi joaopgrassi changed the title Messaging: Clarify span name when destination is temporary/anonymous Messaging: Clarify {destination} value used on span name Dec 13, 2024
@joaopgrassi joaopgrassi merged commit e2227c6 into open-telemetry:main Dec 13, 2024
14 checks passed
@joaopgrassi joaopgrassi deleted the clarify-temporary-destination branch December 13, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Messaging] What to use for {destination} on span name when destination is temporary or anonymous
4 participants