Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcs] add vcs.change.time_to_merge metric #1685

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

adrielp
Copy link
Contributor

@adrielp adrielp commented Dec 14, 2024

Changes

Adds the vcs.change.time_to_merge metric from the GitHub Receiver. It didn't make as part of a previous pull request.

Merge requirement checklist

@adrielp adrielp requested review from a team as code owners December 14, 2024 23:53
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vcs.change.time_to_merge metric was removed in the previous PR following this discussion: #1383 (comment)
I thought that vcs.change.state attribute on the vcs.change.duration metric was sufficient to distinguish them, but it makes sense to have time_to_merge separate.

model/vcs/metrics.yaml Show resolved Hide resolved
model/vcs/metrics.yaml Show resolved Hide resolved
- ref: vcs.ref.head.name
requirement_level: required
- ref: vcs.ref.head.revision
requirement_level: recommended

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the revision attributes be opt-in instead of recommended due to the cardinality issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants