[chore] Enbled make fix can fix table format

[gyliu513]

Fixes #1692

Changes

Please provide a brief description of the changes here.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

• CONTRIBUTING.md guidelines followed.
• Change log entry added, according to the guidelines in When to add a changelog entry.
  • If your PR does not need a change log, start the PR title with [chore]
• schema-next.yaml updated with changes to existing conventions.

[lmolkova]

these files are auto-generated, we should not modify them (and I think whitespaces in jinja are too complicated to format them in this way)

[gyliu513]

@lmolkova make fix-format will update the tables

[lmolkova]

I believe we don't use format checks in the workflows/CI and can probably remove this check from the makefile.

Wonder what @open-telemetry/specs-semconv-maintainers think

[gyliu513]

I believe we don't use format checks in the workflows/CI and can probably remove this check from the makefile.

Yes, we can discuss if we need make fix-format or not, I have added fix-format to CI process in this PR.

[lmolkova]

Yes, we can discuss if we need make fix-format or not, I have added fix-format to CI process in this PR.

as you can see it breaks other checks (registry validation). Personally, I don't see a benefit in format check in MD + yaml repo with MD and yaml lint checks.

[gyliu513]

Thanks @lmolkova , with that, shall we remove both check-format and fix-format from makefile? It is really annoying when running make check.

[lmolkova]

Thanks @lmolkova , with that, shall we remove both check-format and fix-format from makefile? It is really annoying when running make check.

I don't use make check since it takes forever, so I wonder if other @open-telemetry/specs-semconv-maintainers have any thoughts.

[trask]

I don't use make check since it takes forever, so I wonder if other @open-telemetry/specs-semconv-maintainers have any thoughts.

fwiw, the only thing I ever use is make table-generation attribute-registry-generation

[gyliu513]

Hi @lmolkova and @trask , I removed check-format and fix-format in Makefile, hope this is ok, thanks!