-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add system-specific naming guidance #1708
base: main
Are you sure you want to change the base?
Conversation
the system name should be included in the instrument name using the pattern: | ||
`{domain}.{client|server}.{system}.*.{property}` pattern. | ||
|
||
For example, `db.client.cosmosdb.operation.request_charge` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the difference with signalr.server.connection.duration
below makes me think if we should simplify it and do cosmosdb.client.operation.request_charge
. What's the benefit of having db
in front of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
Examples: | ||
|
||
- `db.cassandra.consistency_level` - Describes the consistency level property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to https://github.com/open-telemetry/semantic-conventions/pull/1708/files#r1894523030
what's the benefit of having db
in front of cassandra
here? why not cassandra.consistency_level
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's say we have some redis-specific attributes (and redis can be used as a DB and as a messaging system), would we define db.redis
and messaging.redis
? probably not, it should be just redis
.
Fixes #1494
Related:
azure_
toaz.
incloud.platform
enum values on #1698Documents:
{optional domain}.{system}
pattern{domain}.client|server.{system}
or{system}.client|server
patternclient
orserver
Merge requirement checklist
[chore]