Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpc refactor #235

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Rpc refactor #235

merged 4 commits into from
Nov 29, 2024

Conversation

xlc
Copy link
Member

@xlc xlc commented Nov 29, 2024

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 7.43802% with 112 lines in your changes missing coverage. Please review.

Project coverage is 68.90%. Comparing base (958db5c) to head (6ab1630).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
RPC/Sources/RPC/JSONRPC/RequestParameter.swift 0.00% 53 Missing ⚠️
RPC/Sources/RPC/Server.swift 0.00% 11 Missing ⚠️
RPC/Sources/RPC/Handlers/SystemHandlers.swift 33.33% 8 Missing ⚠️
RPC/Sources/RPC/Handlers/TelemetryHandlers.swift 0.00% 8 Missing ⚠️
RPC/Sources/RPC/Handlers/RPCHandlers.swift 0.00% 7 Missing ⚠️
RPC/Sources/RPC/Handlers/AllHandlers.swift 0.00% 6 Missing ⚠️
RPC/Sources/RPC/JSONRPC/RPCHandler.swift 0.00% 6 Missing ⚠️
RPC/Sources/RPC/Handlers/ChainHandlers.swift 0.00% 5 Missing ⚠️
RPC/Sources/RPC/JSONRPC/FromJSON.swift 16.66% 5 Missing ⚠️
RPC/Sources/RPC/JSONRPC/JSONRPC.swift 33.33% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
- Coverage   69.28%   68.90%   -0.39%     
==========================================
  Files         247      249       +2     
  Lines       18734    18815      +81     
==========================================
- Hits        12980    12964      -16     
- Misses       5754     5851      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xlc xlc merged commit 8344de2 into master Nov 29, 2024
3 of 5 checks passed
@xlc xlc deleted the rpc-refactor branch November 29, 2024 06:56
MacOMNI added a commit that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant