Skip to content

Bump rubocop-rails from 2.28.0 to 2.29.0 #5304

Bump rubocop-rails from 2.28.0 to 2.29.0

Bump rubocop-rails from 2.28.0 to 2.29.0 #5304

Triggered via push January 23, 2025 03:14
Status Failure
Total duration 3m 57s
Artifacts

ci.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

1 error and 16 warnings
lint
Process completed with exit code 1.
scan_ruby
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
slim-lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
lint: app/controllers/account_links_controller.rb#L94
[rubocop] reported by reviewdog 🐶 Use `expect(account_link: [:push_url, :check_uuid_url, :api_key, :name, :proforma_version])` instead. Raw Output: app/controllers/account_links_controller.rb:94:12: C: Rails/StrongParametersExpect: Use `expect(account_link: [:push_url, :check_uuid_url, :api_key, :name, :proforma_version])` instead.
lint: app/controllers/collections_controller.rb#L185
[rubocop] reported by reviewdog 🐶 Use `expect(collection: [:title, :task_ids, :visibility_level, :description, collection_tasks_attributes: collection_tasks_params])` instead. Raw Output: app/controllers/collections_controller.rb:185:12: C: Rails/StrongParametersExpect: Use `expect(collection: [:title, :task_ids, :visibility_level, :description, collection_tasks_attributes: collection_tasks_params])` instead.
lint: app/controllers/comments_controller.rb#L58
[rubocop] reported by reviewdog 🐶 Use `expect(comment: [:text])` instead. Raw Output: app/controllers/comments_controller.rb:58:12: C: Rails/StrongParametersExpect: Use `expect(comment: [:text])` instead.
lint: app/controllers/concerns/task_parameters.rb#L21
[rubocop] reported by reviewdog 🐶 Use `expect(task: [:title, :description, :internal_description, :parent_uuid, :language, :license_id, :programming_language_id, :access_level, files_attributes: file_params, tests_attributes: test_params, model_solutions_attributes: model_solution_params, label_names: []])` instead. Raw Output: app/controllers/concerns/task_parameters.rb:21:12: C: Rails/StrongParametersExpect: Use `expect(task: [:title, :description, :internal_description, :parent_uuid, :language, :license_id, :programming_language_id, :access_level, files_attributes: file_params, tests_attributes: test_params, model_solutions_attributes: model_solution_params, label_names: []])` instead.
lint: app/controllers/concerns/task_parameters.rb#L27
[rubocop] reported by reviewdog 🐶 Use `expect(group_tasks: [group_ids: []])` instead. Raw Output: app/controllers/concerns/task_parameters.rb:27:12: C: Rails/StrongParametersExpect: Use `expect(group_tasks: [group_ids: []])` instead.
lint: app/controllers/groups_controller.rb#L135
[rubocop] reported by reviewdog 🐶 Use `expect(group: [:name, :description])` instead. Raw Output: app/controllers/groups_controller.rb:135:12: C: Rails/StrongParametersExpect: Use `expect(group: [:name, :description])` instead.
lint: app/controllers/labels_controller.rb#L53
[rubocop] reported by reviewdog 🐶 Use `expect(label: [:color])` instead. Raw Output: app/controllers/labels_controller.rb:53:12: C: Rails/StrongParametersExpect: Use `expect(label: [:color])` instead.
lint: app/controllers/messages_controller.rb#L84
[rubocop] reported by reviewdog 🐶 Use `expect(message: [:text, :sender_id, :recipient_id, :sender_status, :recipient_status])` instead. Raw Output: app/controllers/messages_controller.rb:84:12: C: Rails/StrongParametersExpect: Use `expect(message: [:text, :sender_id, :recipient_id, :sender_status, :recipient_status])` instead.
lint: app/controllers/ratings_controller.rb#L29
[rubocop] reported by reviewdog 🐶 Use `expect(rating: [Rating::CATEGORIES])` instead. Raw Output: app/controllers/ratings_controller.rb:29:12: C: Rails/StrongParametersExpect: Use `expect(rating: [Rating::CATEGORIES])` instead.
test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
test: spec/services/proforma_service/import_task_spec.rb#L56
ProformaService::ImportTask#execute when task with same uuid exists in db creates a predecessor for task Failure/Error: expect { import_proforma_task }.to change { task.reload.predecessor }.from(nil).to(be_an(Task)) NoMethodError: undefined method 'predecessor' for an instance of Task
test: spec/services/proforma_service/import_task_spec.rb#L78
ProformaService::ImportTask#execute when task with same uuid exists in db when user does not own task when user is an author of task changes existing task Failure/Error: before { task.authors << user } NoMethodError: undefined method 'authors' for an instance of Task
test: spec/services/proforma_service/import_task_spec.rb#L82
ProformaService::ImportTask#execute when task with same uuid exists in db when user does not own task when user is an author of task creates a predecessor for task Failure/Error: before { task.authors << user } NoMethodError: undefined method 'authors' for an instance of Task
test: spec/services/proforma_service/import_task_spec.rb#L74
ProformaService::ImportTask#execute when task with same uuid exists in db when user does not own task when user is an author of task creates a new task Failure/Error: before { task.authors << user } NoMethodError: undefined method 'authors' for an instance of Task