Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADIOS2: Ensure that a step is always active at write time #1492

Conversation

franzpoeschel
Copy link
Contributor

Even when not using steps, dump everything into a single large step. BP5 will fail otherwise. The PR modifies a BP5 test in a way that would fail before this PR.

Even when not using steps, dump everything into a single large step. BP5
will fail otherwise.
@franzpoeschel franzpoeschel force-pushed the fix-adios2-always-write-inside-an-active-step branch 2 times, most recently from ed9c6d6 to 2c19772 Compare August 3, 2023 14:54
@franzpoeschel franzpoeschel added this to the 0.15.2 milestone Aug 8, 2023
@ax3l ax3l self-assigned this Aug 8, 2023
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed: w/o steps, we might currently create one big step. To be discussed next week.

@ax3l ax3l merged commit a3c1988 into openPMD:dev Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants