Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openPMD version 2.0 to supported API versions #1551

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

franzpoeschel
Copy link
Contributor

@franzpoeschel franzpoeschel commented Nov 3, 2023

This does not yet add any openPMD 2.0 functionality, but serves as a basis for PRs that add new functionality.

This does not yet set 2.0 as the default written version, hence getStandard() needs to be split into getStandard() and getStandardDefault().

  • Maybe add getStandardMax() additionally and deprecate getStandard()?
  • issue warning that 2.0 is in development

@franzpoeschel franzpoeschel added discussion api: new additions to the API labels Nov 3, 2023
@franzpoeschel franzpoeschel mentioned this pull request Nov 3, 2023
4 tasks
@ax3l ax3l self-requested a review November 7, 2023 00:53
@ax3l ax3l added this to the 0.16.0 milestone Nov 7, 2023
@ax3l
Copy link
Member

ax3l commented Nov 7, 2023

Sounds good 👍

We could also separate into default/min/max standard for read and write.

@franzpoeschel franzpoeschel force-pushed the prepare-openPMD-2.0 branch 2 times, most recently from c7e86d4 to 2246928 Compare November 28, 2023 10:35
@franzpoeschel franzpoeschel changed the title Add openPMD version 2.0 to supported API versions [WIP] Add openPMD version 2.0 to supported API versions Dec 11, 2023
@franzpoeschel
Copy link
Contributor Author

Marking this as WIP since I'm using this PR as a common ground for new openPMD 2.0 features and might want to extract more features into it in future.

@franzpoeschel franzpoeschel changed the title [WIP] Add openPMD version 2.0 to supported API versions Add openPMD version 2.0 to supported API versions Oct 28, 2024
@franzpoeschel franzpoeschel enabled auto-merge (squash) October 28, 2024 13:59
@franzpoeschel franzpoeschel mentioned this pull request Oct 28, 2024
@franzpoeschel franzpoeschel merged commit 2593317 into openPMD:dev Oct 29, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: new additions to the API discussion
Projects
Development

Successfully merging this pull request may close these issues.

2 participants