Refactor: Extract ADIOS2 BufferedActions struct to own file, rename to ADIOS2File #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| void markActive(Writable *); | ||
|
|
||
| // bool isActive(std::string const & path); |
Check notice
Code scanning / CodeQL
Commented-out code Note
franzpoeschel
force-pushed
the
refactor-extract-bufferedactions
branch
2 times, most recently
from
b3ab2ad
to
8378185
Compare
franzpoeschel
force-pushed
the
refactor-extract-bufferedactions
branch
from
8378185
to
a0bd5b3
Compare
franzpoeschel
force-pushed
the
refactor-extract-bufferedactions
branch
from
a0bd5b3
to
ebd7eeb
Compare
franzpoeschel
force-pushed
the
refactor-extract-bufferedactions
branch
from
ebd7eeb
to
4a0d217
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a good time to do this since there is only one PR currently modifying the ADIOS2 backend (#1498)
TODO:
@ax3l @guj If you are planning any work on the ADIOS2 backend, please talk to me so we can coordinate this. I'd like to avoid merge conflicts.
Diff: https://github.com/franzpoeschel/openPMD-api/compare/adios2-warn-groupbased-encoding..refactor-extract-bufferedactions