Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Unify Random-Access API and Streaming API into Series::snapshots() #1592

Open
wants to merge 97 commits into
base: dev
Choose a base branch
from
Open

[WIP] Unify Random-Access API and Streaming API into Series::snapshots() #1592

wants to merge 97 commits into from

Commits on Nov 15, 2024

  1. Introduce SharedAttributableData

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    a41857c View commit details
    Browse the repository at this point in the history

  2. Add AbstractSeriesIterator

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    7e53e91 View commit details
    Browse the repository at this point in the history

  3. Derive SeriesIterator from AbstractSeriesIterator

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    643a3ac View commit details
    Browse the repository at this point in the history

  4. Little fix

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    6348704 View commit details
    Browse the repository at this point in the history

  5. Introduce Snapshots.hpp

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3c02216 View commit details
    Browse the repository at this point in the history

  6. Make AbstractSeriesIterator non-virtual

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    c36ae33 View commit details
    Browse the repository at this point in the history

  7. Working commit for Series::snapshots()

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    9b9ca6b View commit details
    Browse the repository at this point in the history

  8. No virtual operator[]

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    e2a5db5 View commit details
    Browse the repository at this point in the history

  9. Remove random-accessing from iterator

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    97d6daa View commit details
    Browse the repository at this point in the history

  10. Introduce AbstractSnapshotsContainer

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    4fce11d View commit details
    Browse the repository at this point in the history

  11. basic random-access iteration

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3749d22 View commit details
    Browse the repository at this point in the history

  12. RandomAccessSnapshots.hpp -> snapshots/RandomAccessIterator.hpp

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    7c19f30 View commit details
    Browse the repository at this point in the history

  13. ReadIterations.hpp -> snapshots/StatefulIterator.hpp

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    42904b4 View commit details
    Browse the repository at this point in the history

  14. SeriesIterator.hpp -> snapshots/IteratorTraits.hpp

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    0087374 View commit details
    Browse the repository at this point in the history

  15. Snapshots.hpp -> snapshots/Snapshots.hpp

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    7e688ad View commit details
    Browse the repository at this point in the history

  16. Move AbstractSnapshotsContainer to ContainerTraits.hpp

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    68d96e5 View commit details
    Browse the repository at this point in the history

  17. Move Container implementations to ContainerImpls.(h|c)pp

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d29abb6 View commit details
    Browse the repository at this point in the history

  18. Fix: parsePreference is not set in file-based iteratione encoding

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    55a1bb2 View commit details
    Browse the repository at this point in the history

  19. Temporarily fix test

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    103d6f0 View commit details
    Browse the repository at this point in the history

  20. Const iteration

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3d57dc1 View commit details
    Browse the repository at this point in the history

  21. Extract stuff to .cpp

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    75b9906 View commit details
    Browse the repository at this point in the history

  22. Reverse iteration

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d1455d3 View commit details
    Browse the repository at this point in the history

  23. Commit missing Snapshots.cpp file

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f7da85e View commit details
    Browse the repository at this point in the history

  24. empty()

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    fe7839f View commit details
    Browse the repository at this point in the history

  25. Revert wrong renaming ReadIterations/StatefulIterator

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    60cdd95 View commit details
    Browse the repository at this point in the history

  26. Rename SeriesIterator -> StatefulIterator

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    a2d5882 View commit details
    Browse the repository at this point in the history

  27. Add ::at, operator[]

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    9088351 View commit details
    Browse the repository at this point in the history

  28. beginStep(): always return relevant iteration indices

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    cb66b97 View commit details
    Browse the repository at this point in the history

  29. Basically working example for snapshots() in write access

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d7928fb View commit details
    Browse the repository at this point in the history

  30. Extract some methods to .cpp

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    108e061 View commit details
    Browse the repository at this point in the history

  31. Fully replace WriteIterations class with the new one

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    2a17e0f View commit details
    Browse the repository at this point in the history

  32. Fix nullpointer issue

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    58f9d71 View commit details
    Browse the repository at this point in the history

  33. Little fixes

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    93c1297 View commit details
    Browse the repository at this point in the history

  34. Add some further API calls

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    0cac092 View commit details
    Browse the repository at this point in the history

  35. Some postfix form transformations

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    47637d5 View commit details
    Browse the repository at this point in the history

  36. Use snapshots() in read example 2

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    5376d1a View commit details
    Browse the repository at this point in the history

  37. Simplify ReadIterations implementation

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    6072007 View commit details
    Browse the repository at this point in the history

  38. Further cleanup

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d02e13c View commit details
    Browse the repository at this point in the history

  39. Change representation of iterations in current step

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    5e7944b View commit details
    Browse the repository at this point in the history

  40. Initiate reading of group/variable-based encoding with nextStep()

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    0c97617 View commit details
    Browse the repository at this point in the history

  41. Prepare internal representation to be aware of steps

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    5fda98d View commit details
    Browse the repository at this point in the history

  42. Windows fixes

    @franzpoeschel
    Pöschel authored and franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    bed0cdf View commit details
    Browse the repository at this point in the history

  43. Adapt tests

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    fca2c64 View commit details
    Browse the repository at this point in the history

  44. Unify close status

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3d1f833 View commit details
    Browse the repository at this point in the history

  45. Add basic test for opening after closing

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    1c9399f View commit details
    Browse the repository at this point in the history

  46. Add new end() iterator representations

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    22ed833 View commit details
    Browse the repository at this point in the history

  47. Reopening logic in Iterator, not yet in Series itself

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    585fbff View commit details
    Browse the repository at this point in the history

  48. Reopening fundamentally working in READ_LINEAR

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    ca51e49 View commit details
    Browse the repository at this point in the history

  49. Extend test 

    still sth wrong in append_mode test, but see about this next week
    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d3fe620 View commit details
    Browse the repository at this point in the history

  50. For now, adapt the append_mode test

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3421c6f View commit details
    Browse the repository at this point in the history

  51. fixes

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    266cd92 View commit details
    Browse the repository at this point in the history

  52. BUGFIX: modifiable attributes, maybe extract this to dev

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    288e24a View commit details
    Browse the repository at this point in the history

  53. Ensure that iterations are never parsed twice

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    0c87061 View commit details
    Browse the repository at this point in the history

  54. Move currently_available_iterations to During_t

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    09d160e View commit details
    Browse the repository at this point in the history

  55. Revert "For now, adapt the append_mode test" 

    This reverts commit 19b68ee.
    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    adedab9 View commit details
    Browse the repository at this point in the history

  56. Remember where we saw what iteration

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3d5bbc8 View commit details
    Browse the repository at this point in the history

  57. Bit of cleanup

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    42f604b View commit details
    Browse the repository at this point in the history

  58. [wip] Groupbased writing: close and reopen

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    473d98c View commit details
    Browse the repository at this point in the history

  59. Further test and implement reopening of Iterations

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    790d157 View commit details
    Browse the repository at this point in the history

  60. Unused variable

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    2546d69 View commit details
    Browse the repository at this point in the history

  61. some fixes to groupbased reopen test

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    290b95d View commit details
    Browse the repository at this point in the history

  62. Filebased reopen in ADIOS2 (no READ_WRITE support yet)

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    115927b View commit details
    Browse the repository at this point in the history

  63. Now supports READ_WRITE too in filebased mode

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    dcca7d1 View commit details
    Browse the repository at this point in the history

  64. Some exceptions for unimplemented stuff

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    e0c68d1 View commit details
    Browse the repository at this point in the history

  65. Works in JSON and HDF5 now too

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    dfaff53 View commit details
    Browse the repository at this point in the history

  66. CI fixes

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    7295ce0 View commit details
    Browse the repository at this point in the history

  67. Virtual destructors

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    003f52b View commit details
    Browse the repository at this point in the history

  68. CI fixes continued

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    034a579 View commit details
    Browse the repository at this point in the history

  69. Some fixes for noexcept specifications

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    9958120 View commit details
    Browse the repository at this point in the history

  70. Further CI Fixes

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    101924b View commit details
    Browse the repository at this point in the history

  71. CI FIXES

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f5a856b View commit details
    Browse the repository at this point in the history

  72. Fixes for ADIOS2 v2.7

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    63e1de9 View commit details
    Browse the repository at this point in the history

  73. placate the intel compiler

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    34633e0 View commit details
    Browse the repository at this point in the history

  74. noexcept details for MSVC

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    384c834 View commit details
    Browse the repository at this point in the history

  75. Fix ulimit test

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    7d7380b View commit details
    Browse the repository at this point in the history

  76. Fix after rebase: dirtyRecursive

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    9603d7a View commit details
    Browse the repository at this point in the history

  77. Fixes after rebase

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    64fef6e View commit details
    Browse the repository at this point in the history

  78. remove conflict markers...

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    eb86065 View commit details
    Browse the repository at this point in the history

  79. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @franzpoeschel
    pre-commit-ci[bot] authored and franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    7311327 View commit details
    Browse the repository at this point in the history

  80. Better defaults?

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    de83d39 View commit details
    Browse the repository at this point in the history

  81. Parameterize Series::snapshots()

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    78b267a View commit details
    Browse the repository at this point in the history

  82. Use enum class for last commit

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f749b4a View commit details
    Browse the repository at this point in the history

  83. Add some missing minor function implementations

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    309b136 View commit details
    Browse the repository at this point in the history

  84. Don't use globbing

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    c5f2b13 View commit details
    Browse the repository at this point in the history

  85. Add missing include

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    7b8f8f6 View commit details
    Browse the repository at this point in the history

  86. Better include structure, put Legacy stuff to Legacy headers

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    5fc528a View commit details
    Browse the repository at this point in the history

  87. Bugfix

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    214ffd0 View commit details
    Browse the repository at this point in the history

  88. Documentation, cleanup

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    af3485b View commit details
    Browse the repository at this point in the history

  89. Add check_recursive_include script

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    9c9cd77 View commit details
    Browse the repository at this point in the history

  90. Fixes after rebase

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    31de818 View commit details
    Browse the repository at this point in the history

  91. Fix bug that hindered files from being properly closed

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    2ca10cb View commit details
    Browse the repository at this point in the history

  92. Will this fix the Windows CI errors I dont think so

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    bb79088 View commit details
    Browse the repository at this point in the history

  93. Use macro instead of function 

    Proper return() is supported beginning with CMake 3.25 only
    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    7fd36fa View commit details
    Browse the repository at this point in the history

  94. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @franzpoeschel
    pre-commit-ci[bot] authored and franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    b9e7661 View commit details
    Browse the repository at this point in the history

  95. Better document reopening options

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3b7d983 View commit details
    Browse the repository at this point in the history

  96. Update close_iteration_test

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    b2dacb8 View commit details
    Browse the repository at this point in the history

  97. WIP: Documentation

    @franzpoeschel
    franzpoeschel committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d278794 View commit details
    Browse the repository at this point in the history