Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDF5 filters (compression) #1644

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

franzpoeschel
Copy link
Contributor

@franzpoeschel franzpoeschel commented Jul 3, 2024

Adds support for filters (e.g. compression) in HDF5.

TODO:

  • Documentation
  • Testing
  • Merge HDF5 independent flush config #1634 first
  • Add a full example workflow for Blosc2/Zstd maybe add some helpers
  • how to verify if a filter is actually effective?

Diff: franzpoeschel/openPMD-api@hdf5-independent-flush-config...hdf5-filters

@franzpoeschel franzpoeschel added backend: HDF5 api: new additions to the API labels Jul 3, 2024
src/IO/HDF5/HDF5IOHandler.cpp Fixed Show fixed Hide fixed
src/IO/HDF5/HDF5IOHandler.cpp Fixed Show fixed Hide fixed
};

template <typename JSON, typename Accessor>
auto parse_filter_by_id(JSON &filter_config, Accessor &&json_accessor)

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 110 lines.
@ax3l ax3l added this to the 0.17.0 milestone Jul 16, 2024
@ax3l ax3l requested review from ax3l and jeanbez July 16, 2024 17:34
@franzpoeschel franzpoeschel force-pushed the hdf5-filters branch 2 times, most recently from 23f7be5 to 233f020 Compare August 5, 2024 09:01
if (parameters.joinedDimension.has_value())
{
error::throwOperationUnsupportedInBackend(
"ADIOS1", "Joined Arrays currently only supported in ADIOS2");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ADIOS1...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: new additions to the API backend: HDF5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants