Dataset-specific JSON/TOML configuration #1646
Conversation
franzpoeschel
force-pushed
the
dataset-specific-config
branch
2 times, most recently
from
3d5b70a
to
37d57ab
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| and is interpreted as a regular expression against which the dataset name | ||
| (full path or path within an iteration) must match.)END"; | ||
| auto throw_up = [&](std::string const &additional_info, | ||
| auto &&...additional_path) { |
Check notice
Code scanning / CodeQL
Unused local variable Note
| and is interpreted as a regular expression against which the dataset name | ||
| (full path or path within an iteration) must match.)END"; | ||
| auto throw_up = [&](std::string const &additional_info, | ||
| auto &&...additional_path) { |
Check notice
Code scanning / CodeQL
Unused static variable Note
| and is interpreted as a regular expression against which the dataset name | ||
| (full path or path within an iteration) must match.)END"; | ||
| auto throw_up = [&](std::string const &additional_info, | ||
| auto &&...additional_path) { |
Check notice
Code scanning / CodeQL
Declaration hides parameter Note
|
|
||
| namespace | ||
| { | ||
| auto readPattern( |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
franzpoeschel
force-pushed
the
dataset-specific-config
branch
4 times, most recently
from
c95a953
to
68dc005
Compare
| std::string merge_impl( | ||
| std::string const &defaultValue, | ||
| std::string const &overwrite, | ||
| MPI_Comm_t &&...comm) |
Check notice
Code scanning / CodeQL
Unused local variable Note
| std::string merge_impl( | ||
| std::string const &defaultValue, | ||
| std::string const &overwrite, | ||
| MPI_Comm_t &&...comm) |
Check notice
Code scanning / CodeQL
Unused static variable Note
franzpoeschel
force-pushed
the
dataset-specific-config
branch
2 times, most recently
from
c0f942e
to
fb7a28e
Compare
franzpoeschel
force-pushed
the
dataset-specific-config
branch
from
fb7a28e
to
5f77a13
Compare
franzpoeschel
force-pushed
the
dataset-specific-config
branch
from
5f77a13
to
64b006d
Compare
franzpoeschel
force-pushed
the
dataset-specific-config
branch
from
64b006d
to
8852258
Compare
might also be good for documentation purposes as JSON is more widely known
franzpoeschel
force-pushed
the
dataset-specific-config
branch
from
8852258
to
a162e8d
Compare
for more information, see https://pre-commit.ci
This was initially prototyped in PIConGPU, search for "extended format for JSON options" on this documentation page.
This moves that functionality over into openPMD.
Look at the diff on
examples/13_write_dynamic_configuration.cppfor an example use case.Bringing this to openPMD makes this functionality available in codes other than PIConGPU, and makes it available from TOML as well as from JSON.
TODO: