Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON Complex Datatype Read #885

Merged
merged 3 commits into from
Jan 8, 2021
Merged

JSON Complex Datatype Read #885

merged 3 commits into from
Jan 8, 2021

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jan 5, 2021 •
edited by franzpoeschel
Loading

Add support to read back complex data back with the JSON backend.
Follow-up to #639

  • add recognition in the JSON backend that COMPLEX datatypes in JSON are not N+1 data

@ax3l ax3l requested a review from franzpoeschel January 5, 2021 21:45
ax3l and others added 2 commits January 8, 2021 12:52
@ax3l @franzpoeschel
Test: JSON Complex Data Read
ba1fba1 
Test reading complex data back with the JSON backend.
@franzpoeschel
JSON: Read complex datasets
d38d5de
@franzpoeschel franzpoeschel force-pushed the topic-complexReadJSON branch from 9ee8164 to d38d5de Compare January 8, 2021 11:54
@franzpoeschel
Copy link
Contributor

Needed to rebase since the fix to #884 was relevant here, too

@franzpoeschel franzpoeschel force-pushed the topic-complexReadJSON branch from 72d7032 to 4fe7462 Compare January 8, 2021 12:12
ax3l
ax3l commented Jan 8, 2021
View reviewed changes
Copy link
Member Author

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, thank you a lot! 🚀 ✨

@ax3l ax3l merged commit d493a73 into openPMD:dev Jan 8, 2021
@ax3l ax3l deleted the topic-complexReadJSON branch January 8, 2021 18:01
franzpoeschel added a commit to franzpoeschel/openPMD-api that referenced this pull request Jan 29, 2021
@ax3l @franzpoeschel
JSON Complex Datatype Read (openPMD#885)
43c8d24 
* Test: JSON Complex Data Read
* JSON: Read complex datasets
* Resize complex datasets correctly

Co-authored-by: Franz Pöschel <[email protected]>
@ax3l ax3l mentioned this pull request Jan 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franzpoeschel franzpoeschel Awaiting requested review from franzpoeschel

Assignees

@franzpoeschel franzpoeschel

Labels
backend: JSON help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ax3l @franzpoeschel