Do not use non-deterministic multithreaded compression when optimizing compression (bsc#1223982 bsc#1223383 jsc#PED-8374). #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compression (bsc#1223982 bsc#1223383 jsc#PED-8374). Using multithreaded compression does not give deterministic results. Not only can the file content vary but the size can also vary significantly. Given there is need to fit the resulting image into certain limit using non-deterministic compression may result in some builds fitting and some not, at random, using same sources and tool.
|
installation-images builds are not reproducible builds anyway. Looking at a few build results I see sizes vary in the few ~100 byte range, if at all. |
|
It will vary a lot more with the local --threads=0 build. I understand that for other platforms that don't mind the ramdisk size it's nice optimization but for ppc it will very likely break the images. |
|
In OBS it's limited to 4 threads which is what out workers have anyway. |
|
Not for local builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using multithreaded compression does not give deterministic results.
Not only can the file content vary but the size can also vary significantly.
Given there is need to fit the resulting image into certain limit using non-deterministic compression may result in some builds fitting and some not, at random, using same sources and tool.