Add support to parse build params from _buildparams file #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow for custom build tweaks such as `-j1` and `--vm-custom-opt=-cpu qemu64` written as separate lines in `_buildparams`
to minimize risk to OBS operations. The pattern for jobs deliberately does not have a * or + to not allow DoS or integer overflows.
bmwiedemann
force-pushed
the
buildparams
branch
from
3bcb66a
to
0317136
Compare
PBuild runs build without chdir into the source-dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow for custom build tweaks such as
-j1and--vm-custom-opt=-cpu qemu64written as separate lines in the_buildparamsfile.This includes regexp whitelist validation to minimize risk to OBS operations.
The pattern for jobs deliberately does not have a
*or+to not allow DoS or integer overflows.The pattern for CPU allows to enable or disable individual CPUID flags. IMHO this should be safe.