-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert variablelist into a HTML tab structure #611
Conversation
This is show the selected tabs content in the tab structure
Hi Toms, in the resulting HTML please replace the class name 'variablelist' with the class name 'tab-structure'.
|
That's now added in commit 2287a1a. Apart from this change, I came across that the Bulma framework (which we use) support tabs already (https://bulma.io/documentation/components/tabs/)... The question is, should we revisit this idea and do it the "Bulma way"? If possible, we shouldn't reinvent the wheel. However, that maybe comes with a price:
On the other side, we could gain something as well:
I was hesitant to commit it, so I post the diff of the change here: diff --git i/source-assets/styles2022/sass/style.sass w/source-assets/styles2022/sass/style.sass
index 59fea29..69cda95 100644
--- i/source-assets/styles2022/sass/style.sass
+++ w/source-assets/styles2022/sass/style.sass
@@ -134,9 +134,15 @@ $i_page_width_wide: $i_superwide
// Upstream imports (must be first!)
-//@import "bulma-0.9.3/bulma/bulma.sass"
+// @import "bulma-0.9.3/bulma/bulma.sass"
+@import "bulma-0.9.3/bulma/sass/utilities/controls"
+@import "bulma-0.9.3/bulma/sass/utilities/extends"
+
@import "bulma-0.9.3/bulma/sass/base/minireset.sass"
@import "bulma-0.9.3/bulma/sass/elements/container.sass"
+@import "bulma-0.9.3/bulma/sass/components/tabs.sass" |
I think I could fixed the issue now. However, there is still one thing that needs to be investigated. If you have only text inside your But as soon as you insert an inline element, the (upstream) stylesheets create a HTML Although I could just retrieve the string value from all elements inside @GGayathri3 Could you look into this issue? As we still have terms that contain other inline elements we need to find a solution for this.
|
Tested it with these browsers:
|
Hi Toms, |
Handled the nesting of HTML elements inside <term>
Changes
Assume you have the following
<variablelist>
:The change in the template converts it into this HTML structure:
TODOs
source-assets/styles2022/sass/custom/content-formal-informal.sass
)suse2022-ns/static/js/script.js
)Related items