Fix JSON-LD generation for single & chunked HTML #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tomschr
commented
Mar 27, 2024
tomschr
commented
- Introduce "handle-json-ld" named template that handles both single and regular HTML
- Introduce xsl:choose inside json-ld-headline to handle the different cases better
* Check for $content != '' instead of just $content * datePublished checks now ancestor nodes too to avoid distracting warning message * categories for DC Dublin Core
tomschr
added
format-html
tomschr
force-pushed
the
metadata-warnings
branch
from
559e424
to
64cd7a6
Compare
tomschr
changed the title
* Create "handle-json-ld" named template that handles both single and chunked HTML * Introduce xsl:choose inside json-ld-headline to handle the different cases better
tomschr
force-pushed
the
metadata-warnings
branch
from
64cd7a6
to
a6a93db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.