Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup-sprint fails due to incorrect board setup #201

Closed
agraul opened this issue Jul 6, 2018 · 1 comment · Fixed by #204
Closed

cleanup-sprint fails due to incorrect board setup #201

agraul opened this issue Jul 6, 2018 · 1 comment · Fixed by #204

Comments

@agraul
Copy link
Member

agraul commented Jul 6, 2018

I came across this issue when I made the burndown generation part of cleanup-sprint optional.

The cli uses the provided --board-id and --target-board-id to setup the boards in this way:

boards = Scrum::Boards.new(@@settings.scrum)
s = Scrum::SprintCleaner.new(@@setting)
s.setup_boards(
  planning_board: boards.planning_board(board_from_id(options['board-id'])),
  target_board: board_from_id(options['target-board-id'])
 )

But the SprintCleaner tries to load the boards in a different way:

def load
  @board = @boards.sprint_board

  @target_board = @boards.target_board
  raise [...] unless target_list
end

def target_list
  @target_list ||= @target_board.lists.find { |l| l.name == @settings.scrum.list_names['planning_ready'] }
end

To fix this, planning_board: should be changed to sprint_board: boards.sprint_board(...).

What made it hard for me to figure this out at first was that we don't test the trollolo cleanup-sprint command yet and that the documentation does not explain which board-id is which (sprint/planning) - leaving me wondering if I gave the board ids correctly (the error was just that specific lists could not be found on the given boards.)

@agraul
Copy link
Member Author

agraul commented Jul 6, 2018

Since I already have this working locally, I'll rebase on top off #199 and add tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant