optional burndown generation on trollolo scrum end-sprint #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the missing board setup that gets passed to Scrum::SprintCleaner
Previously, new burndown data was always generated as part of
`trollolo scrum end-sprint`.
Now it requires an explicit flag:
trollolo scrum end-sprint --burndown-update
The name for this flag is named after `trollolo burndown update`.
test both the new default (no burndown data generation) and the optional cleanup(run_burndown: true)
|
I don't have permissions to request a review, please have a look @matheussbernardo @cornelius @Ana06 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past
trollolo scrum end-sprint(formerlytrollolo cleanup-sprint) generated burndown data every time. Now it requires to be explicitly called with a new flag.This pull request adds a new flag twhich is named after
trollolo burndown update:To add this new flag, I first had to fix a problem with
trollolo scrum end-sprintsince it did not pass the boards toScrum::SprintCleanerFixes #201
I could not figure out how to test the cli (what to mock, and how) and opened #203 for now.