chore: Update .NET Framework Version to 4.8.1 #777
Annotations
5 errors and 14 warnings
|
Examples/BookingSystem.AspNetFramework/Feeds/FacilitiesFeeds.cs#L1
The type or namespace name 'AspNetCore' does not exist in the namespace 'BookingSystem' (are you missing an assembly reference?) [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\Examples\BookingSystem.AspNetFramework\BookingSystem.AspNetFramework.csproj]
|
|
Examples/BookingSystem.AspNetFramework/Feeds/SessionsFeeds.cs#L1
The type or namespace name 'AspNetCore' does not exist in the namespace 'BookingSystem' (are you missing an assembly reference?) [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\Examples\BookingSystem.AspNetFramework\BookingSystem.AspNetFramework.csproj]
|
|
Examples/BookingSystem.AspNetFramework/Stores/FacilityStore.cs#L1
The type or namespace name 'AspNetCore' does not exist in the namespace 'BookingSystem' (are you missing an assembly reference?) [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\Examples\BookingSystem.AspNetFramework\BookingSystem.AspNetFramework.csproj]
|
|
Examples/BookingSystem.AspNetFramework/Stores/SessionStore.cs#L1
The type or namespace name 'AspNetCore' does not exist in the namespace 'BookingSystem' (are you missing an assembly reference?) [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\Examples\BookingSystem.AspNetFramework\BookingSystem.AspNetFramework.csproj]
|
|
|
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2, actions/setup-node@v1, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
|
|
|
|
OpenActive.Server.NET/CustomBookingEngine/CustomBookingEngine.cs#L1
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\OpenActive.Server.NET\OpenActive.Server.NET.csproj::TargetFramework=netstandard2.0]
|
|
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L1
Avoid empty interfaces (https://docs.microsoft.com/visualstudio/code-quality/ca1040-avoid-empty-interfaces) [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\OpenActive.Server.NET\OpenActive.Server.NET.csproj::TargetFramework=netstandard2.0]
|
|
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L1
Exceptions should be public (https://docs.microsoft.com/visualstudio/code-quality/ca1064-exceptions-should-be-public) [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\OpenActive.Server.NET\OpenActive.Server.NET.csproj::TargetFramework=netstandard2.0]
|
|
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L1
Add the following constructor to SilentRollbackException: public SilentRollbackException(string message). (https://docs.microsoft.com/visualstudio/code-quality/ca1032-implement-standard-exception-constructors) [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\OpenActive.Server.NET\OpenActive.Server.NET.csproj::TargetFramework=netstandard2.0]
|
|
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L1
Add the following constructor to SilentRollbackException: public SilentRollbackException(string message, Exception innerException). (https://docs.microsoft.com/visualstudio/code-quality/ca1032-implement-standard-exception-constructors) [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\OpenActive.Server.NET\OpenActive.Server.NET.csproj::TargetFramework=netstandard2.0]
|
|
OpenActive.Server.NET/OpenBookingHelper/Async/AsyncDuplicateLock.cs#L1
Call System.IDisposable.Dispose on object created by 'new SemaphoreSlim(1, 1)' before all references to it are out of scope. (https://docs.microsoft.com/visualstudio/code-quality/ca2000-dispose-objects-before-losing-scope) [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\OpenActive.Server.NET\OpenActive.Server.NET.csproj::TargetFramework=netstandard2.0]
|
|
OpenActive.Server.NET/OpenBookingHelper/Stores/IdempotencyStore.cs#L1
Member CalculateIdempotencyKey does not access instance data and can be marked as static (Shared in VisualBasic) (https://docs.microsoft.com/visualstudio/code-quality/ca1822-mark-members-as-static) [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\OpenActive.Server.NET\OpenActive.Server.NET.csproj::TargetFramework=netstandard2.0]
|
|
OpenActive.Server.NET/OpenBookingHelper/Stores/IdempotencyStore.cs#L1
In externally visible method 'string IdempotencyStore.CalculateIdempotencyKey(OrderIdComponents orderId, string orderJson)', validate parameter 'orderId' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument. (https://docs.microsoft.com/visualstudio/code-quality/ca1062-validate-arguments-of-public-methods) [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\OpenActive.Server.NET\OpenActive.Server.NET.csproj::TargetFramework=netstandard2.0]
|
|
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L1
Consider calling ConfigureAwait on the awaited task (https://docs.microsoft.com/visualstudio/code-quality/ca2007-do-not-directly-await-task) [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\OpenActive.Server.NET\OpenActive.Server.NET.csproj::TargetFramework=netstandard2.0]
|
|
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "core.controlled.all-features", "core.controlled.facilityuse-has-slots", "core.controlled.no-auth", "core.controlled.no-payment-reconciliation", "core.controlled.no-tax-calculation", "core.controlled.prepayment-always-required", "core.controlled.single-seller", "core.random.all-features", "core.random.facilityuse-has-slots", "core.random.no-auth", "core.random.no-payment-reconciliation", "core.random.no-tax-calculation", "core.random.prepayment-always-required", "core.random.single-seller".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
This job failed
Loading