feat: merge Lorem Fitsum features into Reference Implementation feeds #757
Annotations
12 warnings
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-dotnet@v1, actions/setup-node@v1, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1, actions/setup-node@v1, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Build .NET Core Booking Server Reference Implementation
The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/Fakes/OpenActive.FakeDatabase.NET/OpenActive.FakeDatabase.NET.csproj]
|
|
Build .NET Core Booking Server Reference Implementation
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
|
Build .NET Core Booking Server Reference Implementation
Avoid empty interfaces [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
|
Build .NET Core Booking Server Reference Implementation
Exceptions should be public [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
|
Build .NET Core Booking Server Reference Implementation
Add the following constructor to SilentRollbackException: public SilentRollbackException(string message). [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
|
Build .NET Core Booking Server Reference Implementation
Add the following constructor to SilentRollbackException: public SilentRollbackException(string message, Exception innerException). [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
|
Build .NET Core Booking Server Reference Implementation
Call System.IDisposable.Dispose on object created by 'new SemaphoreSlim(1, 1)' before all references to it are out of scope. [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
|
Build .NET Core Booking Server Reference Implementation
In externally visible method 'string IdempotencyStore.CalculateIdempotencyKey(OrderIdComponents orderId, string orderJson)', validate parameter 'orderId' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument. [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
|
Build .NET Core Booking Server Reference Implementation
Member CalculateIdempotencyKey does not access instance data and can be marked as static (Shared in VisualBasic) [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
|
Build .NET Core Booking Server Reference Implementation
Consider calling ConfigureAwait on the awaited task [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
Loading