feat: merge Lorem Fitsum features into Reference Implementation feeds

.github/workflows/openactive-test-suite.yml

@@ -63,10 +63,10 @@ jobs:
       uses: actions/setup-dotnet@v1
       with:
         dotnet-version: 3.1.419
-    - name: Setup Node.js 14.x
+    - name: Setup Node.js 18.17.1
       uses: actions/setup-node@v1
       with:
-        node-version: 14.x
+        node-version: 18.17.1
     - name: Install OpenActive.Server.NET dependencies
       if: ${{ matrix.profile != 'no-auth' && matrix.profile != 'single-seller' }}
       run: dotnet restore ./server/
@@ -136,10 +136,10 @@ jobs:
         repository: openactive/openactive-test-suite
         ref: ${{ steps.refs.outputs.mirror_ref }}
         path: tests
-    - name: Setup Node.js 14.x
+    - name: Setup Node.js 18.17.1
       uses: actions/setup-node@v1
       with:
-        node-version: 14.x
+        node-version: 18.17.1
     - name: Setup MSBuild path
       uses: microsoft/[email protected]
     - name: Setup NuGet

Examples/BookingSystem.AspNetCore/BookingSystem.AspNetCore.csproj

@@ -3,6 +3,7 @@
   <PropertyGroup>
     <TargetFramework>netcoreapp3.1</TargetFramework>
     <UserSecretsId>aspnet-BookingSystem.AspNetCore-443B4F82-A20C-41CE-9924-329A0BCF0D14</UserSecretsId>
+    <Configurations>Release;Debug</Configurations>
   </PropertyGroup>
 
   <ItemGroup>
@@ -22,4 +23,5 @@
     <NoWarn>1701;1702;1591</NoWarn>
   </PropertyGroup>
 
+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' " />
 </Project>

Examples/BookingSystem.AspNetCore/Properties/launchSettings.json

@@ -6,8 +6,7 @@
   "profiles": {
     "BookingSystem.AspNetCore": {
       "commandName": "Project",
-      "launchBrowser": true,
-      "launchUrl": "https://localhost:5001/openactive",
+      "launchUrl": "https://localhost:5002/openactive",
       "applicationUrl": "https://localhost:5001",
       "environmentVariables": {
         "ASPNETCORE_ENVIRONMENT": "Development",

Examples/BookingSystem.AspNetCore/README.md

@@ -6,4 +6,36 @@ This implementation is also used as a reference implementation for the [Test Sui
 
 ## Running Locally
 
+1. In Visual Studio, run the BookingSystem.AspNetCore project
+
+    When it's finished building, it will open a page in your browser with a randomly assigned port e.g. http://localhost:55603/. Make note of this port.
+
+    Head to `http://localhost:{PORT}/openactive` to check that the project is running correctly. You should see an Open Data landing page.
+2. Head to BookingSystem.AspNetCore project options and add an env var using the port you made note of earlier:
+
+    `ApplicationHostBaseUrl: http://localhost:{PORT}`
+3. Now, re-run the project. You're good to go 👍
+
 See the [project contribution documentation](/CONTRIBUTING.md) for details on how to run BookingSystem.AspNetCore locally.
+
+## Reference Implementation Data Generation
+
+Reference Implementation has three main uses that make it very important in the OpenActive ecosystem:
+- For data publishers / booking systems: It is used to demonstrate the properties and shape of data and APIs, according to the OpenActive specifications
+- For data users / brokers: It is used as a trial integration where testing can be done with no ramifications
+- For contributors: It is used to ensure the Test Suite tests are correct and passing, for different combinations of Open Booking API features.
+
+The data for the sample feeds are generated in two places:
+- BookingSystem.AspNetCore/Feeds/*Feeds.cs
+- OpenActive.FakeDatabase.NET/Fakes/FakeBookingSystem.cs
+
+The FakeBookingSystem within OpenActive.FakeDatabase.NET acts as the interface to an example database.
+The example Feeds within BookingSystem.AspNetCore query this interface and translate the data to conform with the OpenActive Modelling Spec.
+
+Due to this split of functionality, the sample data in the feeds are created/transformed in both files, depending on whether they are important to booking
+or not. For example, `Price` is important to booking and there is generated in FakeBookingSystem at startup and stored in the in-memory database. However `Terms Of Service` is not
+needed for booking, and therefore is generated at request time.
+
+### Golden Records
+Golden records are randomly generated records that contain all possible fields specified by the OpenActive Modelling Specification.
+They are unrealistic representations of data, and the presence of all the fields should not be relied on when developing front-end representations of the data.

Examples/BookingSystem.AspNetCore/Stores/FacilityStore.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading.Tasks;
+using BookingSystem.AspNetCore.Helpers;
 using OpenActive.DatasetSite.NET;
 using OpenActive.FakeDatabase.NET;
 using OpenActive.NET;
@@ -320,7 +321,7 @@ protected override async Task GetOrderItems(List<OrderItemContext<FacilityOpport
                     }),
                     Name = facility.Name,
                     Url = new Uri("https://example.com/events/" + slot.FacilityUseId),
-                    Location = _fakeBookingSystem.Database.GetPlaceById(facility.PlaceId),
+                    Location = FeedGenerationHelper.GetPlaceById(facility.PlaceId),
                     FacilityType = new List<Concept> {
                             new Concept
                             {
@@ -374,11 +375,11 @@ protected override async Task GetOrderItems(List<OrderItemContext<FacilityOpport
                             // Note this should always be driven from the database, with new FacilityOpportunity's instantiated
                             Id = RenderOpportunityId(new FacilityOpportunity
                             {
-                                OpportunityType = _appSettings.FeatureFlags.FacilityUseHasSlots ? OpportunityType.FacilityUseSlot :  OpportunityType.IndividualFacilityUseSlot,
+                                OpportunityType = _appSettings.FeatureFlags.FacilityUseHasSlots ? OpportunityType.FacilityUseSlot : OpportunityType.IndividualFacilityUseSlot,
                                 FacilityUseId = slot.FacilityUseId,
                                 SlotId = slot.Id,
                                 IndividualFacilityUseId = !_appSettings.FeatureFlags.FacilityUseHasSlots ? slot.IndividualFacilityUseId : null,
-                            }), 
+                            }),
                             FacilityUse = slotParent,
                             StartDate = (DateTimeOffset)slot.Start,
                             EndDate = (DateTimeOffset)slot.End,

Examples/BookingSystem.AspNetCore/Stores/SessionStore.cs

@@ -8,7 +8,7 @@
 using OpenActive.FakeDatabase.NET;
 using RequiredStatusType = OpenActive.FakeDatabase.NET.RequiredStatusType;
 using System.Threading.Tasks;
-
+using BookingSystem.AspNetCore.Helpers;
 
 namespace BookingSystem
 {
@@ -361,7 +361,7 @@ protected override async Task GetOrderItems(List<OrderItemContext<SessionOpportu
                                 }),
                                 Name = @class.Title,
                                 Url = new Uri("https://example.com/events/" + occurrence.ClassId),
-                                Location = _fakeBookingSystem.Database.GetPlaceById(@class.PlaceId),
+                                Location = FeedGenerationHelper.GetPlaceById(@class.PlaceId),
                                 Activity = new List<Concept>
                                 {
                                     new Concept