chore(criteria): Unit test that criteria ShEx constraints match non-ShEx constraints #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pportunityBookableSellerTermsOfService
…epaymentUnavailable
…ops for numeric constraints
lukehesluke
commented
Feb 20, 2024
Comment on lines
-51
to
+59
| if (reqA[fieldName] != null) { | ||
| return { [fieldName]: reqA[fieldName] }; | ||
| if (extensionConstraint[fieldName] != null && baseConstraint[fieldName] == null) { | ||
| return { [fieldName]: extensionConstraint[fieldName] }; | ||
| } | ||
| if (reqB[fieldName] != null) { | ||
| return { [fieldName]: reqB[fieldName] }; | ||
| if (baseConstraint[fieldName] != null && extensionConstraint[fieldName] == null) { | ||
| return { [fieldName]: baseConstraint[fieldName] }; |
There was a problem hiding this comment.
This seems to me to have been an error. Why have the getValueIfBothExist(..) invokation down below if we'll never reach that because we would return at the first condition.
lukehesluke
commented
Feb 20, 2024
Comment on lines
+95
to
+103
| // The extension should overwrite the base if they both exist | ||
| (base, extension) => extension, | ||
| ), | ||
| ...mergeTestDataNodeConstraintField( | ||
| 'maxinclusive', | ||
| baseConstraint, | ||
| extensionConstraint, | ||
| // The extension should overwrite the base if they both exist | ||
| (base, extension) => extension, |
There was a problem hiding this comment.
This makes more sense to me given that the language is of a Criteria "extending" another. This is a simpler and more explicit means of doing that (and the previous approach was causing the BookableFiveSpaces criteria to generate a capacity constraint of 2 - 5 rather than just 5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #592
For each criteria, generate random data from the ShEx constraints, and check that that data matches the non-ShEx constraints, confirming that they are in alignment.
This work also uncovered a few bugs:
termsOfServiceconstraint in Shape Expression #622It has also spawned a new issue, due to inconsistencies in the modeling presently:
termsOfServiceis inconsistent with other ArrayConstraints #629Note to the reviewer:
/built-types/..files can be ignored during review