feat: Validate data and id #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehesluke
reviewed
Oct 13, 2023
| } | ||
| if ( | ||
| typeof item.data !== 'undefined' | ||
| && (typeof item.data !== 'object' || item.data instanceof Array) |
There was a problem hiding this comment.
Not sure if this is caught by other rules, but this allows for null, which has type object. It could in theory also have other clashes like with Dates, etc, though these are not possible at present as the data comes from JSON parsing.
I would suggest using lodash's isPlainObject function here to be more clear and to be more ironclad
There was a problem hiding this comment.
Good catch @lukehesluke will push a new update that includes this
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPDE validator does not currently test for
dataoridtypes; this PR adds the functionality