Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed battutaStream usage from eea-direct adapter #1071

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Conversation

majesticio
Copy link
Contributor

Removed battutaStream and fetchMetadata functions from eea-direct. Also added some conversions for incorrect units. Not relying on the battuta bucket may have added some locations to our EEA dataset as well.

@majesticio majesticio requested a review from russbiggs January 19, 2024 16:53
Copy link

results:
There are 3 unused packages:

⚠⚠⚠⚠⚠⚠⚠⚠⚠
Unused dependencies:
- JSONStream
- node-fetch
- tz-lookup

@majesticio
Copy link
Contributor Author

closes #1068

Copy link
Member

@russbiggs russbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment is to resolve the now used packages from the unused packages bot JSONStream, node-fetch, tz-lookup

@majesticio majesticio merged commit 04376bc into main Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants