Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot rake task #1350

Closed

Conversation

MutazAshhab
Copy link
Contributor

Could now automatically take screenshots of all social media sharing cards. As described in #1338.

Once #1340 is done we can add task("application:generate:cards").invoke to the daily rake task

@MutazAshhab
Copy link
Contributor Author

CI build failed because of a segmentation fault. Something with sassc

https://app.travis-ci.com/github/openaustralia/publicwhip/jobs/560643935#L821

@mlandauer
Copy link
Member

I've restarted the job on travis 🤞🏼

@MutazAshhab
Copy link
Contributor Author

Another segmentation fault :|

@MutazAshhab
Copy link
Contributor Author

MutazAshhab commented Feb 22, 2022

On this github issue sass/sassc-ruby#197 it discusses the same problem with a previous version of sassc (2.3.0) another person using 2.4.0 had the same error sass/sassc-ruby#197 (comment).

A solution that worked for some is adding this snippet to config/initializers/assets.rb

Rails.application.config.assets.configure do |env|
  env.export_concurrent = false
end

@MutazAshhab
Copy link
Contributor Author

@mlandauer could you take a look at this PR now. I'd like to know if there are any knock on affects after setting export_concurrent = false.

@mlandauer
Copy link
Member

@mlandauer could you take a look at this PR now. I'd like to know if there are any knock on affects after setting export_concurrent = false.

Please make a separate pull request for the export_concurrent change. Then we can check on its own whether it can be safely rolled out to production. Similar to the other pull request I'm going to close this one and wait until you open a new pull request with a cleaned up version history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants