AndroidAutoProtocol 1.6 Support #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slight tweaks - Add isInterleaved boolean - If message is NULL and Frame Type is MIDDLE or LAST, then look for an existing message in buffer (if the message_ is null, then we need a FIRST or BULK frame) - If message is still NULL, then we will create a new message, but recognise it as a valid frame ONLY if this is a FIRST or BULK frame because we cannot start on a MIDDLE or LAST. - Rename recentFrameType to thisFrameType for more accuracy - Only Resolve the Frame if the frame is BULK or LAST and the frame is valid. - If the frame is interleaved, then we will use our interleavedPromise handler. Only resolve the main promise if the frame is not interleaved. - Also reset message once resolved. - Carry on reading if the original promise is not resolved (ie FIRST, MIDDLE, or Interleaved frame) - Add some counters for debugging purposes.
- Have adjusted the buffer mechanism so instead of using the buffer to store a message in the event of an interleaved frame, we basically perform all work on the buffer (albeit we take the existing message for the channel id from the buffer for the frame we're working on and write the message to the buffer if the message isn't resolved). - Moved writing to buffer to receiveFramePayloadHandler() function if the message is BULK or LAST and therefore not resolved. - Simplified receiveFrameHeaderHandler() so that we automatically try to find a message from the buffer and then createa message as necessary depending on the frame type. - Excellent stability with no noticeable artefacts in audio after 1 hour. - Removed majority of debugging after achieving stability.
* Restructure AASDK Proto Protobuf files for Android Auto 1.6 Support based on information from https://milek7.pl/.stuff/galdocs/readme.md This fleshes out enums and other methods with their full naming conventions for better readability and understanding. * Restructure AASDK source/header with additional renames to clarify differences between AudioService, VideoService and AVInput. Updated to MediaSinkService which is extended by AudioMediaSinkService and VideoMediaSinkService which themselves are extended by the individual service channels. * Added initial GenericNotification, MediaBrowser, MediaPlaybackStatus, PhoneStatus, Radio, VendorExtension and WifiProjection services. * Update AASDK_LOG entries for extra consistency * Simplify CMAKE to build and install keeping parameters to a minimum. Default to Release mode and Raspberry PI build unless otherwise specified.
|
@sjdean i think you might need to rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AAP-Proto 1.6 Support and Tidy Ups
This fleshes out enums and other methods with their full naming conventions for better readability and understanding.