Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce duplicate code - button like anchor #1063

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Reduce duplicate code - button like anchor #1063

wants to merge 6 commits into from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jan 15, 2025

We have many buttons using the "button-like-anchor" class. This patch introduces a button component for these buttons, with built-in tooltip and access check to better support common code combinations for those buttons. In and of itself not a particularly impressive component, but the underlying goal here is to push the app more towards using common basic components.

How to test this

Can be tested as usual.

@Arnei Arnei added the type:code-enhancement Internal improvements to the codebase label Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1063

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1063

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited
Loading

This pull request is deployed at test.admin-interface.opencast.org/1063/2025-02-05_09-13-02/ .
It might take a few minutes for it to become available.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@Arnei
Reduce duplicate code - button like anchor
844dd74 
We have many buttons using the "button-like-anchor"
class. This patch introduces a button component
for these buttons, with built-in tooltip and access
check to better support common code combinations
for those buttons.
In and of itself not a particularly impressive
component, but the underlying goal here is to
push the app more towards using common basic
components.
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type:code-enhancement Internal improvements to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Arnei