Fix unique key issue in WizzardStepper #386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arnei
requested changes
May 14, 2024
|
This pull request has conflicts ☹ |
ziegenberg
force-pushed
the
fix-unique-key-issue-in-wizzard
branch
from
aa02f60 to
c191574
Compare
ziegenberg
force-pushed
the
fix-unique-key-issue-in-wizzard
branch
from
c191574 to
4e8106c
Compare
ziegenberg
force-pushed
the
fix-unique-key-issue-in-wizzard
branch
from
7cd629a to
41acd80
Compare
|
This pull request has conflicts ☹ |
Fixes a web console complaint about missing unique keys in the WizzardSteppers. I deem using .filter() a nicer solution than a ternary operator that checks if the hidden property of the current label object is false and rendering an empty fragment. This is probably also what made the console unhappy. Signed-off-by: Daniel Ziegenberg <[email protected]>
ziegenberg
force-pushed
the
fix-unique-key-issue-in-wizzard
branch
from
41acd80 to
0a159d9
Compare
|
Rebased. |
|
This pull request has conflicts ☹ |
|
Can't reproduce the web console warning anymore, so we can probably close this. @ziegenberg, what say you? |
|
Yeah, it was fixed in another way. So, closing it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a web console complaint about missing unique keys in the WizzardSteppers. I deem using .filter() a nicer solution than a ternary operator that checks if the hidden property of the current label object is false and rendering an empty fragment. This is probably also what made the console unhappy.