Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix i18n.options.fallbackLng #406

Merged

Conversation

ziegenberg
Copy link
Member

We used en-US as a source for all translations but had en-GB as a fallback. This is now fixed.

@ziegenberg ziegenberg added the type:bug Something isn't working label May 21, 2024
Copy link
Member

@lkiesow lkiesow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use en-US everywhere else. Looks good.

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

We use en-US as source for all translations but had en-GB as fallback. This is now fixed.

Signed-off-by: Daniel Ziegenberg <[email protected]>
@ziegenberg ziegenberg force-pushed the fix-i18n.options.fallbackLng branch from 9c99d0f to 61eae71 Compare May 24, 2024 12:03
@gregorydlogan gregorydlogan merged commit 1167d2d into opencast:main May 24, 2024
2 checks passed
@ziegenberg ziegenberg deleted the fix-i18n.options.fallbackLng branch May 25, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants