remove partial? vendored frankstein-dependency Fontawesome and replace with react-icons #462
+412
−2,215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziegenberg
added
type:dependencies
|
This pull request has conflicts ☹ |
ziegenberg
force-pushed
the
implement-react-icons-more-broadly
branch
from
9a09238 to
68ba1df
Compare
|
This pull request is deployed at test.admin-interface.opencast.org/462/2024-06-12_11-00-58/ . |
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
ziegenberg
force-pushed
the
implement-react-icons-more-broadly
branch
from
68ba1df to
fa43a48
Compare
I thought about doing this in a more gentle way in replacing it piece by piece. But ripping it out all at once is the easiest option. Related to opencast#429 Signed-off-by: Daniel Ziegenberg <[email protected]>
ziegenberg
force-pushed
the
implement-react-icons-more-broadly
branch
from
fa43a48 to
3c8a1b7
Compare
This package with version 4.7.0 was published 8 years ago. We can do better than this. 'react-icons' also provides FontAwesome icons, so let's use that. Related to opencast#429 Signed-off-by: Daniel Ziegenberg <[email protected]>
Signed-off-by: Daniel Ziegenberg <[email protected]>
ziegenberg
force-pushed
the
implement-react-icons-more-broadly
branch
from
3c8a1b7 to
5f6a9ee
Compare
|
This pull request has conflicts ☹ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought about doing this in a more gentle way by replacing it piece by piece. But ripping it out all at once is the easiest option.
This
font-awesomepackage with version 4.7.0, was published 8 years ago. We can do better than this. 'react-icons' also provides FontAwesome icons, so let's use that.Related to #429