All metadata should be in the metadata step of the add event wizard

[lkiesow]

The “source” step of the add event wizard also contains metadata. This doesn't really make sense since there is a whole step dedicated to metadata. We should move “Start date” in there.

• The problem: This field should only be shown for a file upload. Not for a scheduled event.
• The solution: Make “Source” step 1 and metadata step 2. We then know if we need a start date once we are in the metadata tab.

This fixes #487

[github-actions]

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-691

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-691

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

[github-actions]

This pull request is deployed at test.admin-interface.opencast.org/691/2024-07-23_23-06-17/ .
It might take a few minutes for it to become available.

[mtneug]

Two other fields missing are "location" and "duration" (used for calculating the end date in the Admin UI). I set this for file uploads if I know these files are from a recording (e.g. CA did the recording, but editing was done locally). Is this in the scope of this PR, or should I create another issue?

[lkiesow]

You mean, you want these two additional fields in the recording metadata section? I think that's unrelated enough to not wait for that when merging this pull request. Nevertheless, I'll try taking a peek at the issue since I now kind of know the code and I hope it's not too hard to do.

[mtneug]

You mean, you want these two additional fields in the recording metadata section? I think that's unrelated enough to not wait for that when merging this pull request. Nevertheless, I'll try taking a peek at the issue since I now kind of know the code and I hope it's not too hard to do.

Fair. I created issue #742 to track this.

[Arnei]

Works. But I'm not totally happy with it ^^'.

Does the start date field require special attention? If not, I would prefer if start date was grouped together with the other metadata. Having it in its own special box might set wrong expectations, i.e. "Is 'recording metadata' a different metadata catalog from 'metadata'?".

[Arnei]

This component is a lot of code duplication just because we want to add start date to the event metadata tab. I would prefer if we could avoid this.

[lkiesow]

I've tried that first, but there was more special handling between both since not only the metadata is different, but also the control elements. At the ed it seemed to complicated to me and I gave up. So… yes, I at least thought about this.

[Arnei]

Sooo we merge this as is and leave the consolidation of the two components to someone else? :D

[lkiesow]

Fixed the minor issues and merged the different metadata sections. Now they shouldn't seem like different catalogs any longer.

[Arnei]

Now they shouldn't seem like different catalogs any longer.

Can confirm, looks good to me now.

I was going to complain that we should not need extra code for rendering start_date, as it is part of the standard metadata catalog and therefore should be able to be rendered just like any other metadata field. But it turns the reason we cannot do that is ultimately the backends fault, as the relevant endpoint (admin-ng/event/new/metadata) explicitly excludes start_date (among other fields). Whether or not this is reasonable likely requires additional consideration, so I'm ok with leaving this as it is for now.

[Arnei]

If you schedule a new event and have asset upload configured, the "Previous" button on the metadata tab does nothing. It should bring me back to the "Source" tab.

[lkiesow]

Rebased to resolve merge conflicts and fixed the next/previous problem.

[Arnei]

Can confirm, it is fixed.

Did find another small issue while testing though, sorry :)
The validation for the main metadata is not happening anymore. Effectively this means you could create an event without a title.

[lkiesow]

Rebased to fix resolve conflicts.

The validation for the main metadata is not happening anymore.

Fixed.

[Arnei]

Can confirm, validation is happening again.

But the "Previous" button on the metadata tab does nothing again. Seems to only occur if I want to schedule an event.
Here is a video of me clicking around:
Bildschirmaufzeichnung vom 2024-07-26, 14-48-04.webm

(Edit: Since my mouse is missing from the recording: The one time I jump back to source, I used the circle buttons instead of the "Previous" button)

[github-actions]

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.