checkstyle fixes

[amihaiemil]

Some fixes for #84

[coveralls]

Coverage increased (+0.4%) to 78.673% when pulling 9d84338 on 84 into 6cee9b1 on master.

[amihaiemil]

@rultor merge

[rultor]

@rultor merge

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@amihaiemil Oops, I failed. You can see the full log here (spent 4min)

[ERROR - 2017-01-10T15:30:26.702Z] Session [b5c463f0-d749-11e6-8e0a-83f587388ff8] - page.onError - msg: ReferenceError: Can't find variable: hljs
[ERROR - 2017-01-10T15:30:26.702Z] Session [b5c463f0-d749-11e6-8e0a-83f587388ff8] - page.onError - stack:
  (anonymous function) (http://eva.amihaiemil.com/index.html:16)
[INFO  - 2017-01-10T15:30:31.233Z] ShutdownReqHand - _handle - About to shutdown
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 72.408 sec - in com.amihaiemil.charles.GraphCrawlITCase
Running com.amihaiemil.charles.sitemap.SitemapXmlOnlineITCase
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.35 sec - in com.amihaiemil.charles.sitemap.SitemapXmlOnlineITCase
Running com.amihaiemil.charles.SitemapXmlCrawlITCase
Jan 10, 2017 3:30:33 PM org.openqa.selenium.phantomjs.PhantomJSDriverService <init>
INFO: executable: /usr/local/bin/phantomjs
Jan 10, 2017 3:30:33 PM org.openqa.selenium.phantomjs.PhantomJSDriverService <init>
INFO: port: 19012
Jan 10, 2017 3:30:33 PM org.openqa.selenium.phantomjs.PhantomJSDriverService <init>
INFO: arguments: [--webdriver=19012, --webdriver-logfile=/home/r/repo/phantomjsdriver.log]
Jan 10, 2017 3:30:33 PM org.openqa.selenium.phantomjs.PhantomJSDriverService <init>
INFO: environment: {}
PhantomJS is launching GhostDriver...
[INFO  - 2017-01-10T15:30:33.508Z] GhostDriver - Main - running on port 19012
[INFO  - 2017-01-10T15:30:33.702Z] Session [ba254d10-d749-11e6-9c3e-a3bb9fa766f7] - page.settings - {"XSSAuditingEnabled":false,"javascriptCanCloseWindows":true,"javascriptCanOpenWindows":true,"javascriptEnabled":true,"loadImages":true,"localToRemoteUrlAccessEnabled":false,"userAgent":"Mozilla/5.0 (Unknown; Linux x86_64) AppleWebKit/534.34 (KHTML, like Gecko) PhantomJS/1.9.8 Safari/534.34","webSecurityEnabled":true}
[INFO  - 2017-01-10T15:30:33.702Z] Session [ba254d10-d749-11e6-9c3e-a3bb9fa766f7] - page.customHeaders:  - {}
[INFO  - 2017-01-10T15:30:33.702Z] Session [ba254d10-d749-11e6-9c3e-a3bb9fa766f7] - Session.negotiatedCapabilities - {"browserName":"phantomjs","version":"1.9.8","driverName":"ghostdriver","driverVersion":"1.1.0","platform":"linux-unknown-64bit","javascriptEnabled":true,"takesScreenshot":true,"handlesAlerts":false,"databaseEnabled":false,"locationContextEnabled":false,"applicationCacheEnabled":false,"browserConnectionEnabled":false,"cssSelectorsEnabled":true,"webStorageEnabled":false,"rotatable":false,"acceptSslCerts":false,"nativeEvents":true,"proxy":{"proxyType":"direct"}}
[INFO  - 2017-01-10T15:30:33.702Z] SessionManagerReqHand - _postNewSessionCommand - New Session Created: ba254d10-d749-11e6-9c3e-a3bb9fa766f7
[ERROR - 2017-01-10T15:30:33.904Z] Session [ba254d10-d749-11e6-9c3e-a3bb9fa766f7] - page.onError - msg: ReferenceError: Can't find variable: hljs
[ERROR - 2017-01-10T15:30:33.904Z] Session [ba254d10-d749-11e6-9c3e-a3bb9fa766f7] - page.onError - stack:
  (anonymous function) (http://eva.amihaiemil.com/:16)
[INFO  - 2017-01-10T15:30:38.398Z] ShutdownReqHand - _handle - About to shutdown
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.824 sec - in com.amihaiemil.charles.SitemapXmlCrawlITCase

Results :

Tests in error: 
  LiveWebPageITCase.retrievesLinksFromPage:71 » StaleElementReference {"errorMes...
  LiveWebPageITCase.retrievesLinksFromPageCname:56 » StaleElementReference {"err...

Tests run: 9, Failures: 0, Errors: 2, Skipped: 0

[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent! The file encoding for reports output files should be provided by the POM property ${project.reporting.outputEncoding}.
[INFO] 
[INFO] --- maven-failsafe-plugin:2.19.1:verify (default) @ charles ---
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent! The file encoding for reports output files should be provided by the POM property ${project.reporting.outputEncoding}.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:12 min
[INFO] Finished at: 2017-01-10T15:30:39+00:00
[INFO] Final Memory: 27M/391M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.19.1:verify (default) on project charles: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
container ae3f621f61531816fe463a71d63b9e3e5ddf75130756a37493276327a0500034 is dead
Tue Jan 10 15:30:54 UTC 2017

[amihaiemil]

@rultor try to merge again

[rultor]

@rultor try to merge again

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor try to merge again

@amihaiemil Done! FYI, the full log is here (took me 4min)