Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Markham scraper finding regional and ward councillors separately #441

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Fix Markham scraper finding regional and ward councillors separately #441

merged 4 commits into from
Nov 1, 2024

Conversation

bzhangjma
Copy link
Contributor

Correct xpaths and finding regional and ward councillors separately.

@jpmckinney
Copy link
Member

jpmckinney commented Oct 30, 2024 •
edited
Loading

Do pip install pre-commit and pre-commit install

Then run pre-commit run --all-files

It will make your life much easier.

@jpmckinney jpmckinney merged commit ed22c5a into opencivicdata:master Nov 1, 2024
3 checks passed
@jpmckinney
Copy link
Member

I merged and tidied the code in 4853a95 and 746369d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzhangjma @jpmckinney