Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sampler version #309

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Update sampler version #309

merged 4 commits into from
Jan 24, 2025

Conversation

Sukh-P
Copy link
Member

@Sukh-P Sukh-P commented Jan 23, 2025

Pull Request

Description

Update to latest sampler version to support site training with solar coordinate + date/time trig values

How has this been tested?

Adding new test data in the correct format to test the site pipeline, running this locally to check training runs successfully

@Sukh-P Sukh-P marked this pull request as ready for review January 23, 2025 12:29
@Sukh-P Sukh-P requested review from dfulu and AUdaltsova January 23, 2025 12:29
Comment on lines +10 to +11
file_path: PLACEHOLDER
metadata_file_path: PLACEHOLDER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

Copy link
Contributor

@AUdaltsova AUdaltsova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for this!

@Sukh-P Sukh-P merged commit 4d11931 into dev-data-sampler Jan 24, 2025
3 checks passed
@Sukh-P Sukh-P deleted the update-dsampler-version branch January 24, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants