Incorporate SiteSample and UKRegionalSample into save/load #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
felix-e-h-p
changed the title
pvnet/data/site_datamodule.py
Outdated
| sample = convert_netcdf_to_numpy_sample(ds) | ||
| return sample | ||
| sample = SiteSample.load(self.sample_paths[idx]) | ||
| return sample.to_numpy() |
peterdudfield
approved these changes
Jan 29, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-data-sampler #311 +/- ##
===================================================
Coverage ? 60.86%
===================================================
Files ? 28
Lines ? 1817
Branches ? 0
===================================================
Hits ? 1106
Misses ? 711
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
So I reckon as @dfulu had previously suggested here #301 (comment) for the loading and to_numpy bits this can be abstracted a bit more to essentially one |
Sukh-P
reviewed
Jan 29, 2025
Sukh-P
requested changes
Jan 29, 2025
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sukh-P
reviewed
Jan 30, 2025
Sukh-P
approved these changes
Jan 30, 2025
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
save_samples.py, site_datamodule.py and uk_regional_datamodule.py updated accordingly to utilise new SiteSample and UKRegionalSample save/load functionality.
Additional test added for clarity and version update stated in dependencies.