Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PremadeSampleDataset signature #312

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Update PremadeSampleDataset signature #312

merged 1 commit into from
Jan 30, 2025

Conversation

Sukh-P
Copy link
Member

@Sukh-P Sukh-P commented Jan 30, 2025

Pull Request

Description

Update signature and type hint for sample class

@Sukh-P Sukh-P requested a review from felix-e-h-p January 30, 2025 12:50
@Sukh-P Sukh-P marked this pull request as ready for review January 30, 2025 12:57
@Sukh-P Sukh-P merged commit 79dca28 into dev-data-sampler Jan 30, 2025
5 checks passed
@Sukh-P Sukh-P deleted the update-signature-base-datamodule branch January 30, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felix-e-h-p felix-e-h-p felix-e-h-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sukh-P @felix-e-h-p